On Fri, Nov 01, 2024 at 02:59:38PM +0000, Jonathan Cameron wrote: > On Fri, 1 Nov 2024 15:16:00 +0200 > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > Dan reported that ddata might be used uninitialised in some cases. > > Let's initialise it to NULL (patches 1 - 3). With that, update one driver > > to drop an unneeded anymore check (included in patch 3). > > > > While at it, one more cleanup to kxcjk-1013 (patch 4) is added. > > > > Jonathan, dunno if you want to rebase at this stage (probably not), > > but if you do, feel free to fold the patches 1-3 to the initial code. > Ah. I've just picked v2, but given I squashed anyway the commit message > changes don't matter. Thanks, I have looked into the resulting changes and it all LGTM! > I was curious what Assing meant but not need to > ask given I wasn't going to keep it. He-he :-) -- With Best Regards, Andy Shevchenko