On Sat, 26 Oct 2024 15:58:52 +0100 Rayyan Ansari <rayyan@xxxxxxxxx> wrote: > On 26/10/2024 12:16, Jonathan Cameron wrote: > > On Thu, 24 Oct 2024 22:04:56 +0300 > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > >> The mentioned change effectively broke the ODR startup timeouts > >> settungs for KX023-1025 case. Let's revert it for now and see > >> how we can handle it with the better approach after switching > >> the driver to use data structure instead of enum. > >> > >> This reverts commit d5cbe1502043124ff8af8136b80f93758c4a61e0. > >> > >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > I'll take this the slow way as I don't think there is time to chase the revert > > through the various trees and still get the dependent patches in. > > Hopefully we will fairly quickly get the missing table data and can > > bring this back again. > > > > For now, applied to the togreg branch of iio.git. > > I have tagged it as a fix though. and +CC Rayyan > > (I'm guessing maybe that will bounce as you rarely miss people you should > > CC!) > Hi, > Sorry for not replying earlier, I've just caught up with the discussion. > > I don't fully understand why this is breaking KX023-1025, but you know > more than I do here. > Does this not mean that the use of KX022-1020 in the 3 devices (Lumia > 640, 640 XL, 735) using this from qcom-msm8226-microsoft-common.dtsi > will now be broken? > Yes. The issues in the currently driver is here https://elixir.bootlin.com/linux/v6.12-rc4/source/drivers/iio/accel/kxcjk-1013.c#L321 This array is indexed using the enum https://elixir.bootlin.com/linux/v6.12-rc4/source/drivers/iio/accel/kxcjk-1013.c#L176 and the new entry for the KX022-1020 mean we are one short of those startup time definitions. Without that the values retrieved for the KX022-1025 are all 0. It should be a relatively easy fix if we have those times. One side effect of this series of Andy's is that it makes it much harder to have similar bugs in future. Jonathan > Thanks, > Rayyan
