On Sat, 5 Oct 2024 22:42:43 +0530 Abhash jha <abhashkumarjha123@xxxxxxxxx> wrote: > > Hi Abhash, > > > > Some comments below. > > > Hi Jonathan, > I will do the fixes and send a v3. > > I have a question though: > The device has a 8 x 16-bit HW-buffer. > I want to implement the HW buffer support. Where in this driver should > I read the hardware buffer? If it were a fifo there are lots of examples in tree, but those tend to 'empty' on read. From your description I'm not sure this one does. > How is that exposed to userspace? Is it even exposed? > There is no buffer-full interrupt, It just has the latest 16 range > measurements and > latest 8 ALS measurements. Ah. Can we tell if the data is new vs data we have already read?
