> Hi Abhash, > > Some comments below. > Hi Jonathan, I will do the fixes and send a v3. I have a question though: The device has a 8 x 16-bit HW-buffer. I want to implement the HW buffer support. Where in this driver should I read the hardware buffer? How is that exposed to userspace? Is it even exposed? There is no buffer-full interrupt, It just has the latest 16 range measurements and latest 8 ALS measurements. There is also a SYSTEM_HISTORY_CTRL register, which configures the HW buffer, like setting which data to capture (ALS/RANGE) as well as turning the buffer on/off. Where should all this configuration be done? Should it be default or have some sysfs attribute associated with it? Thanks, Abhash
