On Sun, Sep 01, 2024 at 02:59:41PM +0100, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Use irq_get_trigger_type() to replace getting the irq data then the > type in two steps. ... > - irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq)); > + irq_trig = irq_get_trigger_type(irq); Same remark about comment vs. assignment. > /* > * Configure the interrupt generator hardware to supply whatever > * the interrupt is configured for, edges low/high level low/high, -- With Best Regards, Andy Shevchenko