Re: [PATCH v2 6/8] dt-bindings: iio: adc: document diff-channels corner case for some ADCs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 02, 2024 at 01:36:29PM +0300, Alexandru Ardelean wrote:
> Some ADCs have channels with negative and positive inputs, which can be
> used to measure differential voltage levels. These inputs/pins are
> dedicated (to the given channel) and cannot be muxed as with other ADCs.
> 
> For those types of setups, the 'diff-channels' property can be specified to
> be used with the channel number (or reg property) for both negative and
> positive inputs/pins.
> 
> Signed-off-by: Alexandru Ardelean <aardelean@xxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/iio/adc/adc.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> index 8e7835cf36fd..9b7a8e149639 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> @@ -37,6 +37,10 @@ properties:
>        to both the positive and negative inputs of a differential ADC.
>        The first value specifies the positive input pin, the second
>        specifies the negative input pin.
> +      There are also some ADCs, where the differential channel has dedicated
> +      positive and negative inputs which can be used to measure differential
> +      voltage levels. For those setups, this property can be configured with
> +      the the 'reg' property (i.e. diff-channels = <reg reg>).

Please run scripts/checkpatch.pl and fix reported warnings. Then please
run  and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.

Best regards,
Krzysztof





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux