Re: [PATCH] iio: imu: inv_mpu6050: Remove duplicate code between labels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 2, 2024 at 7:04 PM Jean-Baptiste Maneyrol
<Jean-Baptiste.Maneyrol@xxxxxxx> wrote:
>
> Hello,
>
> it would be true if there was a return statement before the 2 labels, and that the 2 lables were only error handling case.
>
> But this is not the case, since end_session label is the end of the normal end of the function, not error handling. This is very old code and not very clear, I'm sorry about that.
>
> But the modifications are breaking the code and interrupt handling will not work correctly anymore, since inv_reset_fifo() will be called now every time the function is called.
>
> Best regards,
> JB

I apologize for the confusion, I just realized the logic is incorrect
as well. I didn't test it because I thought it trivial, I will send
patch after verification.





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux