On Sat, Aug 24, 2024 at 01:18:06PM +0200, Vasileios Amoiridis wrote: > On Fri, Aug 23, 2024 at 10:15:29PM +0300, Andy Shevchenko wrote: > > On Fri, Aug 23, 2024 at 08:17:10PM +0200, Vasileios Amoiridis wrote: ... > > > + ret = regmap_update_bits(data->regmap, BMP580_REG_DSP_IIR, > > > + BMP580_DSP_IIR_PRESS_MASK | > > > + BMP580_DSP_IIR_TEMP_MASK, reg_val); > > > > Better to split on logical bounds > > > > ret = regmap_update_bits(data->regmap, BMP580_REG_DSP_IIR, > > BMP580_DSP_IIR_PRESS_MASK | BMP580_DSP_IIR_TEMP_MASK, > > reg_val); > > This goes beyond the 80 char limit. I know that there is the relaxed > limit of 100 chars but I didn't feel it was more readable like this. > I could definitely use it though, thanks! The readability has a priority over that limit. That's even mentioned in the documentation besides the relaxed limit. -- With Best Regards, Andy Shevchenko
