On Sat, Aug 24, 2024 at 09:45:43AM +0200, Krzysztof Kozlowski wrote: > On Fri, Aug 23, 2024 at 08:17:12PM +0200, Vasileios Amoiridis wrote: > > Add interrupt options for BMP3xx and BMP5xx devices as well. > > > > Signed-off-by: Vasileios Amoiridis <vassilisamir@xxxxxxxxx> > > --- > > Documentation/devicetree/bindings/iio/pressure/bmp085.yaml | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml > > index 6fda887ee9d4..eb1e1ab3dd18 100644 > > --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml > > +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml > > @@ -48,9 +48,14 @@ properties: > > > > interrupts: > > description: > > - interrupt mapping for IRQ (BMP085 only) > > + interrupt mapping for IRQ. Supported in BMP085, BMP3xx, BMP5xx > > Supported by driver or device? > If the latter, this should be constrained per device variant in > allOf:if:then:. > Hi Krzysztof, Supported by some devices controlled by the same (just 1) driver. Thanks for the hint, I will take a look how other drivers do it :) > > > maxItems: 1 > > > > + drive-open-drain: > > Missing type, unless some other core schema defined it? But then I > actually wonder if we need it. Maybe this should be interrupt flag? > Just like GPIO has such. I took it from the bindings/iio/imu/bosch,bmi323.yaml example which is the same. You think something needs to change? Cheers, Vasilis > > Best regards, > Krzysztof >
