Re: [PATCH v8 2/2] iio: light: ROHM BH1745 colour sensor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/08/2024 11:28, Matti Vaittinen wrote:
On 7/19/24 01:02, Mudit Sharma wrote:
Add support for BH1745, which is an I2C colour sensor with red, green,
blue and clear channels. It has a programmable active low interrupt
pin. Interrupt occurs when the signal from the selected interrupt
source channel crosses set interrupt threshold high or low level.

Interrupt source for the device can be configured by enabling the
corresponding event. Interrupt latch is always enabled when setting
up interrupt.

Add myself as the maintainer for this driver in MAINTAINERS.

Signed-off-by: Mudit Sharma <muditsharma.info@xxxxxxxxx>
Reviewed-by: Ivan Orlov <ivan.orlov0322@xxxxxxxxx>
Reviewed-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>

Hi Mudit & All :)

I know I am late. The series has already been applied (thanks Jonathan!). I've mostly been offline for the last 1.5 months or so - "all work and no play makes Jack a dull boy", you know ;)

Anyways, as Jonathan asked me to take a look at the GTS stuff (at v7), I tried to quickly glance at this. It looks good to me!

Well, the real test will be the users of the sensor driver - so please let us know if GTS stuff brings problems to users. I am mostly interested in knowing if gain changes caused by integration time changes are handled gracefully by the users. :) Well, seeing there is no per- channel gain or integration time setting, you should be safe from the worst side-effects :)

Nice driver!

Hi Matti,

Thank you for your review on this :)

Best regards,
Mudit Sharma

Yours,
     -- Matti






[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux