On 03/08/2024 12:39, Jonathan Cameron wrote: >> >>> + >>> +unevaluatedProperties: false >> >> I don't see any other $ref. Don't you miss adc.yaml? Or channels? Or >> some more properties? This looks incomplete for ADC. > > It's acceptable on ADCs in particular (but more generally) > to just assume all channels are exposed. They may all be wired > to internal power lines anyway, in which case what is there is > a chip feature. This only works if their isn't any channel specific > configuration, then not providing the channels child nodes is fine. > > However, that requires us to be fairly sure there won't ever be > a per channel thing that needs configuring from DT. > That's generally only the case in simple devices. > > So might be better to put the channels nodes in there and deal with > dynamic channel configuration (so don't present any without > a channel node) from the start as it's more future proof. OK. Then anyway this should be additionalProperties: false (unless I missed somewhere $ref?). Best regards, Krzysztof
