Re: [PATCH v3 3/3] dt-bindings: iio: light: stk33xx: add compatible for stk3013

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2024-07-22 17:05, Conor Dooley wrote:
> On Sun, Jul 21, 2024 at 03:44:31PM +0530, Kaustabh Chakraborty wrote:
>> STK3013 is a proximity sensor by Sensortek, bearing chipid of 0x31. Despite
>> being marketed as a proximity sensor, it also appears to have ambient
>> light sensing capabilities.
>> 
>> The part is fully compatible with the existing implementation of the
>> device driver. Add the compatible string of stk3013 to the existing
>> list, with a fallback of stk3310.
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/iio/light/stk33xx.yaml | 13 +++++++++----
>>  1 file changed, 9 insertions(+), 4 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/iio/light/stk33xx.yaml b/Documentation/devicetree/bindings/iio/light/stk33xx.yaml
>> index f6e22dc9814a..d5f6b622c8da 100644
>> --- a/Documentation/devicetree/bindings/iio/light/stk33xx.yaml
>> +++ b/Documentation/devicetree/bindings/iio/light/stk33xx.yaml
>> @@ -18,10 +18,15 @@ allOf:
>>  
>>  properties:
>>    compatible:
>> -    enum:
>> -      - sensortek,stk3310
>> -      - sensortek,stk3311
>> -      - sensortek,stk3335
>> +    oneOf:
>> +      - enum:
>> +        - sensortek,stk3310
>> +        - sensortek,stk3311
>> +        - sensortek,stk3335
>> +      - items:
>> +        - enum:
>> +          - sensortek,stk3013
>> +        - const: sensortek,stk3310
>>  
> 
> ./Documentation/devicetree/bindings/iio/light/stk33xx.yaml:23:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> ./Documentation/devicetree/bindings/iio/light/stk33xx.yaml:27:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> ./Documentation/devicetree/bindings/iio/light/stk33xx.yaml:28:11: [warning] wrong indentation: expected 12 but found 10 (indentation)
> 
> From dt_binding_check, please fix.

Will get fixed in v4.
Thanks.

> 
>>    reg:
>>      maxItems: 1
>> 
>> -- 
>> 2.45.2
>>




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux