On 20/07/2024 17:29, Jonathan Cameron wrote:
On Thu, 18 Jul 2024 23:02:06 +0100
Mudit Sharma <muditsharma.info@xxxxxxxxx> wrote:
Add support for BH1745, which is an I2C colour sensor with red, green,
blue and clear channels. It has a programmable active low interrupt
pin. Interrupt occurs when the signal from the selected interrupt
source channel crosses set interrupt threshold high or low level.
Interrupt source for the device can be configured by enabling the
corresponding event. Interrupt latch is always enabled when setting
up interrupt.
Add myself as the maintainer for this driver in MAINTAINERS.
Signed-off-by: Mudit Sharma <muditsharma.info@xxxxxxxxx>
Reviewed-by: Ivan Orlov <ivan.orlov0322@xxxxxxxxx>
Reviewed-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
Hi Mudit.
Rather than go around again, I've applied a few things I noticed
and changes Javier suggests whilst picking this up.
Hi Jonathan,
Thank you for reviewing and applying the changes.
I also tweaked a few long lines.
Anyhow, applied to the testing branch of iio.git which will be rebased
on rc1 once available and pushed out as togreg for linux-next to
pick up.
Thanks,
Jonathan
+
+ i2c_set_clientdata(client, indio_dev);
Trivial, but is this ever used? I couldn't figure out where it if is.
So I've dropped it. Shout if it needs to be here.
This isn't used and can be dropped.
Thank you.
Best regards,
Mudit Sharma
