> -----Original Message----- > From: Conor Dooley <conor@xxxxxxxxxx> > Sent: Tuesday, July 16, 2024 11:58 PM > To: Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; Jonathan Cameron <jic23@xxxxxxxxxx>; David > Lechner <dlechner@xxxxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; > Liam Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; > Dimitri Fedrau <dima.fedrau@xxxxxxxxx>; Krzysztof Kozlowski > <krzk+dt@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Conor Dooley > <conor+dt@xxxxxxxxxx>; Hennerich, Michael > <Michael.Hennerich@xxxxxxxxxx>; Nuno Sá <noname.nuno@xxxxxxxxx> > Subject: Re: [PATCH v7 4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml > > [External] > > On Tue, Jul 16, 2024 at 01:50:23AM +0000, Paller, Kim Seer wrote: > > > > > > > -----Original Message----- > > > From: Conor Dooley <conor@xxxxxxxxxx> > > > Sent: Tuesday, July 16, 2024 12:18 AM > > > To: Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx> > > > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; > > > devicetree@xxxxxxxxxxxxxxx; Jonathan Cameron <jic23@xxxxxxxxxx>; David > > > Lechner <dlechner@xxxxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; > > > Liam Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown > <broonie@xxxxxxxxxx>; > > > Dimitri Fedrau <dima.fedrau@xxxxxxxxx>; Krzysztof Kozlowski > > > <krzk+dt@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Conor Dooley > > > <conor+dt@xxxxxxxxxx>; Hennerich, Michael > > > <Michael.Hennerich@xxxxxxxxxx>; Nuno Sá <noname.nuno@xxxxxxxxx> > > > Subject: Re: [PATCH v7 4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml > > > > > > [External] > > > > > > On Sun, Jul 14, 2024 at 09:29:58PM +0800, Kim Seer Paller wrote: > > > > Add documentation for ltc2664. > > > > > > > > Co-developed-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > > > > Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > > > > Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx> > > > > > > IIRC I gave you a reviewed-by on v5, was there a particular reason you > didn't > > > add it? > > > > I made changes to the 'output-range-microvolt' logic in v6, which I thought > > might require a new review. If your 'Reviewed-by' tag still applies, please let > me know. > > IIRC what I said was along the lines of "with the logic from the > previous version, Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>". > Is that what you did? Yes. Additionally, considering Krzysztof's recent comment about the mixed indentation in the example section, should I send a new patch version that includes this indentation fix along with adding your Reviewed-by tag?
