On Wed, 3 Jul 2024 18:29:43 +0200
Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Wed, Jul 03, 2024 at 06:45:06PM +0300, Aleksandr Mishin wrote:
> > In ad9834_write_frequency() clk_get_rate() can return 0. In such case
> > ad9834_calc_freqreg() call will lead to division by zero. Checking
> > 'if (fout > (clk_freq / 2))' doesn't protect in case of 'fout' is 0.
> > ad9834_write_frequency() is called from ad9834_write(), where fout is
> > taken from text buffer, which can contain any value.
> >
> > Modify parameters checking.
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Fixes: 12b9d5bf76bf ("Staging: IIO: DDS: AD9833 / AD9834 driver")
> > Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > Signed-off-by: Aleksandr Mishin <amishin@xxxxxxxxxx>
> > ---
> > v1->v2: Check if clk_freq == 0 directly instead of fout == 0
> > as suggested by Dan
>
>
> Thanks!
>
> Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
Applied and marked for stable.
> regards,
> dan carpenter
>
