Hi Conor,
On 6/25/24 17:34, Conor Dooley wrote:
On Tue, Jun 25, 2024 at 05:07:13PM +0200, Olivier Moysan wrote:
Add documentation of device tree bindings to support
sigma delta modulator backend in IIO framework.
Signed-off-by: Olivier Moysan <olivier.moysan@xxxxxxxxxxx>
I don't review bindings for a job, I can only reliably get to look at
my mail queue in the evenings, please give me a chance to reply to you
before you submit a new version.
Sorry, the short review delay.
+$id: http://devicetree.org/schemas/iio/adc/sd-modulator-backend.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sigma delta modulator backend
Same comments about filename and title apply here as the previous
version. "TI $foo Sigma Delta Modulator" and drop the reference to back
ends or the pretence of being generic.
The logic here is the same as for the former sigma delta modulator
driver. (see discussion [1])
I mean introducing a generic and minimalist driver to support sd
modulators, but not dedicated to a specific modulator. The ads1201 is
chosen as a basic modulator here. But it is rather an arbitrary choice.
I agree "backend" reference is not really relevant here. I have to think
about a way to manage the coexistence of this sigma delta modulator
driver with its former version.
[1] https://lore.kernel.org/all/6943aaf5-b580-0fd1-7a2e-b99f7a266388@xxxxxx/
BRs
Olivier
Thanks,
Conor.
