On Sat, 2024-06-08 at 19:06 +0100, Jonathan Cameron wrote: > On Thu, 6 Jun 2024 09:22:38 +0200 > Nuno Sa <nuno.sa@xxxxxxxxxx> wrote: > > > Use dev_err_probe() (and variants) in the probe() path. While at it, made > > some simple improvements: > > * Explicitly included the err.h and errno.h headers; > > * Removed some unnecessary line breaks; > > * Removed a redundant 'else'; > > * Added some missing \n to prink. > > > > Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx> > > --- > > > > @@ -1296,8 +1268,8 @@ static int ltc2983_reg_access(struct iio_dev > > *indio_dev, > > > > if (readval) > > return regmap_read(st->regmap, reg, readval); > > - else > > - return regmap_write(st->regmap, reg, writeval); > > + > > + return regmap_write(st->regmap, reg, writeval); > > } > > Unrelated. > > Otherwise updates look correct to me. Yeah, I know. It was simple enough that I sneaked it in and did mentioned it in the commit message hoping it would make the change acceptable in here :) - Nuno Sá