On Fri, 2024-03-29 at 14:06 -0500, David Lechner wrote: > On Thu, Mar 28, 2024 at 8:23 AM Nuno Sa via B4 Relay > <devnull+nuno.sa.analog.com@xxxxxxxxxx> wrote: > > > > From: Nuno Sa <nuno.sa@xxxxxxxxxx> > > > > This adds the bindings documentation for the 14 bit > > RF Digital-to-Analog converter. > > > > Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx> > > --- > > .../devicetree/bindings/iio/dac/adi,ad9739a.yaml | 88 ++++++++++++++++++++++ > > MAINTAINERS | 8 ++ > > 2 files changed, 96 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad9739a.yaml > > b/Documentation/devicetree/bindings/iio/dac/adi,ad9739a.yaml > > new file mode 100644 > > index 000000000000..24bcec763a9b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad9739a.yaml > > @@ -0,0 +1,88 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/dac/adi,ad9739a.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Analog Devices AD9739A RF DAC > > + > > +maintainers: > > + - Dragos Bogdan <dragos.bogdan@xxxxxxxxxx> > > + - Nuno Sa <nuno.sa@xxxxxxxxxx> > > + > > +description: | > > + The AD9739A is a 14-bit, 2.5 GSPS high performance RF DACs that are capable > > + of synthesizing wideband signals from dc up to 3 GHz. > > + > > + > > https://www.analog.com/media/en/technical-documentation/data-sheets/ad9737a_9739a.pdf > > + > > +properties: > > + compatible: > > + enum: > > + - adi,ad9739a > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > I also see an IRQ pin on the datasheet. Do we need an interrupts > property for that? > Likely we'll never use it. But yes, it can be documented in the bindings... > > + > > + reset-gpios: > > + maxItems: 1 > > + > > + vdd_3_3-supply: > > + description: 3.3V Digital input supply. > > vdd33-supply would better match the datasheet name > > > + > > + vdd-supply: > > + description: 1.8V Digital input supply. > > + > > + vdda-supply: > > + description: 3.3V Analog input supply. > > + > > + vddc-supply: > > + description: 1.8V Clock input supply. > > I see a VREF voltage reference input in the datasheet. Do we need a vref-supply? Same as the IRQ pin. - Nuno Sá
