On Sat, 2024-03-16 at 21:38 +0200, Andy Shevchenko wrote: > Thu, Feb 29, 2024 at 04:10:27PM +0100, Nuno Sa kirjoitti: > > Use the new cleanup magic for handling mutexes in IIO. This allows us to > > greatly simplify some code paths. > > ... > > > ret = iio_scan_mask_query(indio_dev, buffer, this_attr->address); > > if (ret < 0) > > - goto error_ret; > > - if (!state && ret) { > > - ret = iio_scan_mask_clear(buffer, this_attr->address); > > - if (ret) > > - goto error_ret; > > - } else if (state && !ret) { > > + return ret; > > + > > + if (state && ret) > > + return len; > > I would leave the original checks. It's natural pattern > It was suggested by Jonathan to have it like it is now (and no strong feelings from my side)... - Nuno Sá