[PATCH v2 00/14] device property / IIO: Use cleanup.h magic for fwnode_handle_put() handling.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

Changes since v1:
- Introduced device_for_each_child_node_scoped()
  We may need equivalents for fwnode_for_each_child_node_scoped() etc,
  but this is the only one I needed so far.
  This followed from a discussion of the equivalent patch set for
  device_for_each_of_node() which lead to bringing the declaration of
  the handle we are applying the __free() to into the for_* loop
  initialization.  The avoided issues with the declaration (which also
  effects cleanup order) being nowhere near where it was first set to
  something non NULL.  The disadvantage is that the declaration of that
  local variable is not obvious from the macro parameters. Bugs
  due to variable shadowing might occur, though in many cases those
  are apparent as compiler warnings about use of uninitialized variables.
- Reordered patches to drag the ltc2983 which is teh one case that
   wasn't a loop next to the patch that enables that simpler handling.
   Also move the struct fwnode_handle *ref declarations to where they
   are intialized.  This may look odd, but Linus and others have stated
   this is how they prefer this to be done.
- Converted the one instance of fwnode_for_each_available_child_node()
  over to device_for_each_child_node_scoped() as it never needed
  to be the fwnode version in the first place - that was probably a
  misunderstanding of _available_ or not.
- Dropped tags other than Andy's on the first patch (as that was unchanged
  other than simplifying the patch description).  The code changed too
  much for me to carry them forwards.

As can be seen by the examples from IIO that follow this can save
a reasonable amount of complexity and boiler plate code, often enabling
additional cleanups in related code such as use of
return dev_err_probe().

Merge wise (assuming everyone is happy), I'd propose an immutable branch
(in IIO or elsewhere) with the 1st and 3rd patches on it, so that we can
start making use of this in other areas of the kernel without having to wait too long.

Note I don't have the hardware so this is compile tested only.
Hence I'd appreciate some Tested-by tags if anyone can poke one of the
effected drivers.

Julia Lawal has posted some nice coccinelle magic for the DT equivalents.
Referenced from that cover letter.  Similar may help us convert more
drivers to use this new approach, but often hand tweaking can take
additional advantage of other cleanup.h based magic, or things like
return dev_err_probe().

Jonathan Cameron (14):
  device property: Add cleanup.h based fwnode_handle_put() scope based
  iio: temp: ltc2983: Use __free(fwnode_handle) to replace
    fwnode_handle_put() calls
  device property: Introduce device_for_each_child_node_scoped()
  iio: adc: max11410: Use device_for_each_child_node_scoped()
  iio: adc: mcp3564: Use device_for_each_child_node_scopd()
  iio: adc: qcom-spmi-adc5: Use device_for_each_child_node_scopd()
  iio: adc: rzg2l_adc: Use device_for_each_child_node_scopd()
  iio: adc: stm32: Use device_for_each_child_node_scoped()
  iio: adc: ti-ads1015: Use device_for_each_child_node_scoped()
  iio: adc: ti-ads131e08: Use device_for_each_child_node_scoped()
  iio: addac: ad74413r: Use device_for_each_child_node_scoped()
  iio: dac: ad3552r: Use device_for_each_child_node_scoped()
  iio: dac: ad5770r: Use device_for_each_child_node_scoped()
  iio: dac: ltc2688: Use device_for_each_child_node_scoped()

 drivers/iio/adc/max11410.c        | 27 +++--------
 drivers/iio/adc/mcp3564.c         | 16 +++----
 drivers/iio/adc/qcom-spmi-adc5.c  |  7 +--
 drivers/iio/adc/rzg2l_adc.c       | 11 ++---
 drivers/iio/adc/stm32-adc.c       | 63 ++++++++++---------------
 drivers/iio/adc/ti-ads1015.c      |  5 +-
 drivers/iio/adc/ti-ads131e08.c    | 13 ++----
 drivers/iio/addac/ad74413r.c      | 10 +---
 drivers/iio/dac/ad3552r.c         | 51 ++++++++-------------
 drivers/iio/dac/ad5770r.c         | 19 +++-----
 drivers/iio/dac/ltc2688.c         | 24 +++-------
 drivers/iio/temperature/ltc2983.c | 76 ++++++++++---------------------
 include/linux/property.h          |  8 ++++
 13 files changed, 113 insertions(+), 217 deletions(-)


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux