On Fri, 9 Feb 2024 08:33:11 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 08/02/2024 11:40, Subhajit Ghosh wrote: > > Hi Krzysztof, > > > > On 8/2/24 18:47, Krzysztof Kozlowski wrote: > >> On 06/02/2024 14:00, Subhajit Ghosh wrote: > >>> Add vdd-supply property which is valid and useful for all the > >>> devices in this schema. > >> > >> Why is it useful? How is it useful? DT describes the hardware, not > >> because something is "useful". > > I am adding this property based on a previous review: > > https://lore.kernel.org/all/20240121153655.5f734180@jic23-huawei/ > > The property was there already. > > > > > Does the below commit message in this context make sense to you? > > "Add vdd-supply property for all the devices in this schema." > > It's still poor. You should say why, e.g. because devices have it. I'd change the patch title to: dt-bindings: iio: light: adps9300: Add missing vdd-supply For description something simple like: All devices covered by the binding have a vdd supply. > > >> > >>> > >>> this patch depends on patch: > >>> "dt-bindings: iio: light: Merge APDS9300 and APDS9960 schemas" > >> > >> This is unrelated and does not make any sense in commit msg. Drop. > > Apologies for the silly questions: > > What does the "Drop" signify? Are you asking me to drop/delete the above > > "...patch depends..." message or does it have any other meaning? > > Drop entire paragraph. > > > Best regards, > Krzysztof >
