On Sat, 27 Jan 2024 15:07:26 +0000 Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On Wed, 24 Jan 2024 19:14:35 -0800 > Saravana Kannan <saravanak@xxxxxxxxxx> wrote: > > > On Tue, Jan 23, 2024 at 7:14 AM Nuno Sa via B4 Relay > > <devnull+nuno.sa.analog.com@xxxxxxxxxx> wrote: > > > > > > From: Nuno Sa <nuno.sa@xxxxxxxxxx> > > > > > > The property is io-channels and not io-channel. This was effectively > > > preventing the devlink creation. > > I'm a bit lost on the devlink side of things. Is this something with > effects on existing drivers before this patch set, or is it only causing > real problems with the changes in here? > > i.e. Should we mark it for stable and rush it in as a fix, or can it wait > for the rest of the set? > I'm also fine with this going via DT tree if that makes more sense. If that happens. Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > Jonathan > > > > > Thank you! > > > > Reviewed-by: Saravana Kannan <saravanak@xxxxxxxxxx> > > > > > > > > > Fixes: 8e12257dead7 ("of: property: Add device link support for iommus, mboxes and io-channels") > > > Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx> > > > --- > > > drivers/of/property.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > > index 641a40cf5cf3..bbf0dee2fb9c 100644 > > > --- a/drivers/of/property.c > > > +++ b/drivers/of/property.c > > > @@ -1244,7 +1244,7 @@ DEFINE_SIMPLE_PROP(clocks, "clocks", "#clock-cells") > > > DEFINE_SIMPLE_PROP(interconnects, "interconnects", "#interconnect-cells") > > > DEFINE_SIMPLE_PROP(iommus, "iommus", "#iommu-cells") > > > DEFINE_SIMPLE_PROP(mboxes, "mboxes", "#mbox-cells") > > > -DEFINE_SIMPLE_PROP(io_channels, "io-channel", "#io-channel-cells") > > > +DEFINE_SIMPLE_PROP(io_channels, "io-channels", "#io-channel-cells") > > > DEFINE_SIMPLE_PROP(interrupt_parent, "interrupt-parent", NULL) > > > DEFINE_SIMPLE_PROP(dmas, "dmas", "#dma-cells") > > > DEFINE_SIMPLE_PROP(power_domains, "power-domains", "#power-domain-cells") > > > > > > -- > > > 2.43.0 > > > > >