Hello Marius, a quick static scan reported the following On Mon, Jan 22, 2024 at 10:47:12AM +0200, marius.cristea@xxxxxxxxxxxxx wrote: > From: Marius Cristea <marius.cristea@xxxxxxxxxxxxx> > > This is the iio driver for Microchip > PAC193X series of Power Monitor with Accumulator chip family. [..] > + mutex_init(&info->lock); > + ret = devm_add_action_or_reset(&client->dev, pac1934_mutex_destroy, > + &info->lock); > + > + /* > + * do now any chip specific initialization (e.g. read/write > + * some registers), enable/disable certain channels, change the sampling > + * rate to the requested value > + */ > + ret = pac1934_chip_configure(info); > + if (ret < 0) > + return ret; the previous assignation of ret is never used, so either dead code or you might have wanted to return early based on it's value. cheers, peter -- petre rodan
Attachment:
signature.asc
Description: PGP signature
