On Mon, 22 Jan 2024 09:34:36 -0600 Rob Herring <robh@xxxxxxxxxx> wrote: > On Sun, Jan 21, 2024 at 05:17:20PM +0000, Jonathan Cameron wrote: > > On Fri, 19 Jan 2024 11:15:56 -0600 > > Rob Herring <robh@xxxxxxxxxx> wrote: > > > > > On Fri, 19 Jan 2024 17:00:48 +0100, Nuno Sa wrote: > > > > 'adi,adc-dev' is now deprecated and must not be used anymore. Hence, > > > > also remove it from being required. > > > > > > > > The reason why it's being deprecated is because the axi-adc CORE is now > > > > an IIO service provider hardware (IIO backends) for consumers to make use > > > > of. Before, the logic with 'adi,adc-dev' was the opposite (it was kind > > > > of consumer referencing other nodes/devices) and that proved to be wrong > > > > and to not scale. > > > > > > > > Now, IIO consumers of this hardware are expected to reference it using the > > > > io-backends property. Hence, the new '#io-backend-cells' is being added > > > > so the device is easily identified as a provider. > > > > > > > > Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx> > > > > --- > > > > Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml | 8 +++++--- > > > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > yamllint warnings/errors: > > > ./Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml:45:5: [error] syntax error: could not find expected ':' (syntax) > > If this is all that comes up for v6, I can fix it up whilst applying. > > I would not recommend that unless you run the DT checks. This is a YAML > error which is just the first thing that has to be valid. After that, we > check against the DT meta-schema. Then we check all the examples > (because any example could use any schema). I would indeed test it (plus let 0-day hit it before I expose it to next as well) so hopefully nothing would sneak through. > > Though, it looks like the above is the only issue. Turned out, not quite - though others also fairly minor, there are enough of them I expect Nuno will do a v7. > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> Thanks Jonathan > > Rob
