On Fri, 2024-01-12 at 17:39 +0000, Jonathan Cameron wrote:
> On Fri, 12 Jan 2024 17:40:22 +0100
> Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@xxxxxxxxxx> wrote:
>
> > From: Nuno Sa <nuno.sa@xxxxxxxxxx>
> >
> > Move to the IIO backend framework. Devices supported by adi-axi-adc now
> > register themselves as backend devices.
> >
> > Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx>
>
> A few quick drive by comments whist I wait for a build to finish...
>
> > diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c
> > index 0f21d1d98b9f..741b53c25bb1 100644
> > --- a/drivers/iio/adc/adi-axi-adc.c
> > +++ b/drivers/iio/adc/adi-axi-adc.c
> > @@ -8,6 +8,7 @@
> > > static int adi_axi_adc_probe(struct platform_device *pdev)
> > {
> ...
>
> > @@ -390,37 +205,23 @@ static int adi_axi_adc_probe(struct platform_device
> > *pdev)
> > if (ret)
> > return ret;
> >
> > - if (cl->info->version > ver) {
> > + if (*expected_ver > ver) {
> > dev_err(&pdev->dev,
> > "IP core version is too old. Expected %d.%.2d.%c,
> > Reported %d.%.2d.%c\n",
>
> Format doesn't match with later.
>
> > - ADI_AXI_PCORE_VER_MAJOR(cl->info->version),
> > - ADI_AXI_PCORE_VER_MINOR(cl->info->version),
> > - ADI_AXI_PCORE_VER_PATCH(cl->info->version),
> > + ADI_AXI_PCORE_VER_MAJOR(*expected_ver),
> > + ADI_AXI_PCORE_VER_MINOR(*expected_ver),
> > + ADI_AXI_PCORE_VER_PATCH(*expected_ver),
> > ADI_AXI_PCORE_VER_MAJOR(ver),
> > ADI_AXI_PCORE_VER_MINOR(ver),
> > ADI_AXI_PCORE_VER_PATCH(ver));
> > return -ENODEV;
> > }
> >
> > - indio_dev->info = &adi_axi_adc_info;
> > - indio_dev->name = "adi-axi-adc";
> > - indio_dev->modes = INDIO_DIRECT_MODE;
> > - indio_dev->num_channels = conv->chip_info->num_channels;
> > - indio_dev->channels = conv->chip_info->channels;
> > -
> > - ret = adi_axi_adc_config_dma_buffer(&pdev->dev, indio_dev);
> > + ret = devm_iio_backend_register(&pdev->dev, &adi_axi_adc_generic,
> > st);
> > if (ret)
> > return ret;
> >
> > - ret = adi_axi_adc_setup_channels(&pdev->dev, st);
> > - if (ret)
> > - return ret;
> > -
> > - ret = devm_iio_device_register(&pdev->dev, indio_dev);
> > - if (ret)
> > - return ret;
> > -
> > - dev_info(&pdev->dev, "AXI ADC IP core (%d.%.2d.%c) probed\n",
> > + dev_info(&pdev->dev, "AXI ADC IP core (%d.%.2d.%d) probed\n",
> I'd rip this (I think) unrelated change out to reduce noise in here somewhat.
> I'm curious though as it's still %c above.
Oh, just forgot about the above %c... Yeah, the %c format gives a crappy output.
That's why I changed it :)
- Nuno Sá
