On Wed, Dec 27, 2023 at 06:34:25PM +0200, Andy Shevchenko wrote: > On Sun, Dec 24, 2023 at 04:34:52PM +0200, Petre Rodan wrote: > > Fix indentation and whitespace in code that will not get refactored. > > > > Make URL inside comment copy-paste friendly. > > > return dev_err_probe(dev, ret, > > - "honeywell,pmin-pascal could not be read\n"); > > + "honeywell,pmin-pascal could not be read\n"); > > As done elsewhere, here and in other similar places fix the indentation > by making first character on the latter line to be in the same column as > the first character after the opening parenthesis. I triple-checked that I am following the max 80 column rule, the parenthesis rule and the 'do not split printk messages' rules in all my code in these 10 patches. precisely so I don't get feedback like this one. if the parenthesis rule makes the line longer then 80 chars I right-align to column 80 as seen above. that is what I understand from the latest coding style document and that is what I will follow. in this particular case if I were to ignore the 80 column rule we would end up on column 90 if I were to follow your feedback (open parenthesis is at column 45 and the error takes 45 chars more). peter
Attachment:
signature.asc
Description: PGP signature
