Re: [PATCH] iio: adc: ti-ads1015: support deferred probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 05, 2023 at 09:13:28AM +0300, Tomas Melin wrote:
> On 04/09/2023 14:23, Andy Shevchenko wrote:
> > On Mon, Sep 04, 2023 at 01:15:22PM +0300, Tomas Melin wrote:

...

> >> +out:
> >> +	if ((ret == -EAGAIN) || (ret == -ENXIO))
> >> +		return -EPROBE_DEFER;
> >> +	return ret;
> > 
> > Oh my... This looks so-o hackish.> If anything, it has to be fixed on the level of regmap I2C APIs or
> so.As such this does fix a real world issue. Providing some helpers for
> this on regmap level would probably be great. To add such an API I
> suspect there should first be existing users for it, and this would be
> one example.
> Until there would be such an generic API, I'm not sure if there are many
> other alternatives than to check for invalid returns and defer the probe.

As Jonathan said, please try to elaborate better what the real word issue is,
how it can be reproduced, etc.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux