Re: [PATCH] iio: pressure: bmp280: Fix NULL pointer exception

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 11 Aug 2023 19:38:09 +0200
Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> On Fri, Aug 11, 2023 at 5:58 PM Phil Elwell <phil@xxxxxxxxxxxxxxx> wrote:
> 
> > The bmp085 EOC IRQ support is optional, but the driver's common probe
> > function queries the IRQ properties whether or not it exists, which
> > can trigger a NULL pointer exception. Avoid any exception by making
> > the query conditional on the possession of a valid IRQ.
> >
> > Fixes: aae953949651 ("iio: pressure: bmp280: add support for BMP085 EOC interrupt")
> > Signed-off-by: Phil Elwell <phil@xxxxxxxxxxxxxxx>  
> 
> Looks like a logic mistake.
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
I've applied this locally but given my tree is currently ahead of its
parent ready for the merge to happen, I won't push this out until
char-misc-next has been merged upstream.

Thanks,

Jonathan

> 
> Yours,
> Linus Walleij





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux