Hi Andy Shevchenko, > Subject: Re: [PATCH] iio: chemical: vz89x: Convert enum->pointer for data > in the match tables > > On Sat, Aug 12, 2023 at 06:27:18PM +0100, Biju Das wrote: > > Convert enum->pointer for data in the match tables, so that > > device_get_match_data() can do match against OF/ACPI/I2C tables, once > > i2c bus type match support added to it. > > > > Replace enum->struct *vz89x_chip_data for data in the match table. > > Simplify the probe() by replacing device_get_match_data() and ID > > lookup for retrieving data by i2c_get_match_data(). > > > While at it, drop unused variables id and chip_id from probe(). > > So, I'm not going to repeat, you have to fix this in all commit messages > like this. Agreed. Cheers, Biju > > Otherwise, > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > -- > With Best Regards, > Andy Shevchenko >
