RE: [PATCH] iio: chemical: atlas-ezo-sensor: Simplify probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy Shevchenko,

> Subject: Re: [PATCH] iio: chemical: atlas-ezo-sensor: Simplify probe()
> 
> On Sat, Aug 12, 2023 at 05:34:25PM +0100, Biju Das wrote:
> > Simplify the probe() by replacing device_get_match_data() and ID
> > lookup match by i2c_get_match_data() as we have similar I2C and
> > DT-based matching table.
> 
> > While at it, drop id variable from probe() as it is unused.
> 
> As somebody noticed, this "while at it" part is misleading.
> It's integral part of the change.

Agreed, will drop this and send v2.

Cheers,
Biju

> 
> With that fixed,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> --
> With Best Regards,
> Andy Shevchenko
> 





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux