> > I'd prefer to just drop this reg_update function entirely. Put the call inline so > that we can use FIELD_PREP() directly rather than (after fixing the probably > bug) passing in both the value and the mask. > > > > > but it looks like there is still a bug in max14001_reg_update(), so > > I'd prefer Kim Seer Paller to revisit this issue and submit a properly > > tested patch. > > Absolutely agree. If it's outstanding in few weeks though we can go > with an educated 'guess' for the fix but I'd really rather not if Kim can post a fix > in the meantime. Thank you all for your input and feedback. I'm currently working on the fix and will test it as soon as I have access to the eval boards again. I'll reach out if something needs to be clarified. Thanks, Kim