On 23-07-02, Jonathan Cameron wrote: > On Wed, 21 Jun 2023 21:41:05 +0100 > Conor Dooley <conor@xxxxxxxxxx> wrote: > > > On Wed, Jun 21, 2023 at 06:08:57PM +0200, Marco Felsch wrote: > > > Datarate (dr) is a 3-bit wide register field. Values from 0 to 7 are > > > allowed for all devices but only for the ADS1115 devices a value of 7 > > > does make a difference. > > > > > > While on it fix the description of the datarate for ADS1115 devices as > > > well. > > > > > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > > > --- > > > .../devicetree/bindings/iio/adc/ti,ads1015.yaml | 15 +++++++++++++-- > > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml > > > index 2127d639a7683..e004659099c19 100644 > > > --- a/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml > > > +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml > > > @@ -78,9 +78,9 @@ patternProperties: > > > ti,datarate: > > > $ref: /schemas/types.yaml#/definitions/uint32 > > > minimum: 0 > > > - maximum: 6 > > > + maximum: 7 > > > description: | > > > - Data acquisition rate in samples per second > > > + Data acquisition rate in samples per second for ADS1015, TLA2024 > > > 0: 128 > > > 1: 250 > > > 2: 490 > > > @@ -88,6 +88,17 @@ patternProperties: > > > 4: 1600 (default) > > > 5: 2400 > > > 6: 3300 > > > + 7: 3300 > > > + > > > + Data acquisition rate in samples per second for ADS1115 > > > + 0: 8 > > > + 1: 16 > > > + 2: 32 > > > + 3: 64 > > > + 4: 128 (default) > > > + 5: 250 > > > + 6: 475 > > > + 7: 860 > > > > I'll leave this one to Rob or Krzysztof to ack/review, but this does > > seem like as good an opportunity as any to migrate to a property that > > allows you to put the actual data acquisition rate in & not have to add > > new key-value mappings to the binding to support devices with differing > > schemes. > > I agree a value would have been better, but now we are where we are, > I'm not sure it's worth the churn of changing it - particularly as the > driver will need to support the old binding for every anyway. Yep, this would be an API change :/ Regards, Marco
