Re: [PATCH v3 2/2] iio: adc: max14001: New driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 9 Jun 2023 01:55:17 +0800
Kim Seer Paller <kimseer.paller@xxxxxxxxxx> wrote:

> The MAX14001 is configurable, isolated 10-bit ADCs for multi-range
> binary inputs.
> 
> Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
The driver initialises a regmap then doesn't use it.
Fine not to use it, but get rid of the setup code, structures and include
as well. I assume this got forgotten after testing the code worked when it
wasn't used.

Other than that looks fine to me.

Jonathan
 



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux