> > > + .wr_table = &aio_ctl_wr_table, > > > + .rd_table = &aio_ctl_rd_table, > > > + .volatile_table = &aio_ctl_volatile_table, > > > + .cache_type = REGCACHE_FLAT, > > > +}; > > > > Do we need regmap lock? > > I think the regmap lock is opt-out, so I don't think we need to set an > custom lock callback for the regmaps in this driver. > > Jonathan, do read_raw() and write_raw() require explicit locking? The don't provide their own locking. Depending on the access pattern the underlying bus locking may be sufficient. If you have read modify write cycles though you'll want locking at the appropriate level for that which might well be at the level of regmap. Jonathan
