On 04/03/2023 01:41, Andrew Hepp wrote: > Add support for the MCP9600 thermocouple EMF converter. > > Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/MCP960X-Data-Sheet-20005426.pdf > Signed-off-by: Andrew Hepp <andrew.hepp@xxxxxxxxx> Thank you for your patch. There is something to discuss/improve. > +description: | Drop '|' > + https://ww1.microchip.com/downloads/en/DeviceDoc/MCP960X-Data-Sheet-20005426.pdf > + > +properties: > + compatible: > + const: microchip,mcp9600 > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 1 > + maxItems: 6 > + > + interrupt-names: > + minItems: 1 > + maxItems: 6 > + items: > + enum: The interrupts should be usually strictly ordered and you allow any combinations. Why? Why are they optional? > + - open > + - short > + - alert1 > + - alert2 > + - alert3 > + - alert4 > + > + thermocouple-type: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Type of thermocouple (THERMOCOUPLE_TYPE_K if omitted). > + Use defines in dt-bindings/iio/temperature/thermocouple.h. > + Supported types are B, E, J, K, N, R, S, T. > + > + vdd-supply: > + description: Regulator that provides power to the sensor. > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> No need for this header. > + #include <dt-bindings/iio/temperature/thermocouple.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + mcp9600@60 { Node names should be generic, so temp-sensor, thermocouple or something else matching the type. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "microchip,mcp9600"; > + reg = <0x60>; Best regards, Krzysztof
