On 18/01/2023 07:38, Okan Sahin wrote: > Add ADI MAX77541/MAX77540 devicetree document. > > Signed-off-by: Okan Sahin <okan.sahin@xxxxxxxxxx> > --- > .../devicetree/bindings/mfd/adi,max77541.yaml | 87 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 88 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/adi,max77541.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/adi,max77541.yaml b/Documentation/devicetree/bindings/mfd/adi,max77541.yaml > new file mode 100644 > index 000000000000..91d15e9ca2e3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/adi,max77541.yaml > @@ -0,0 +1,87 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/adi,max77541.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MAX77540/MAX77541 PMIC from ADI > + > +maintainers: > + - Okan Sahin <okan.sahin@xxxxxxxxxx> > + > +description: | > + MAX77540 is a Power Management IC with 2 buck regulators. > + > + MAX77541 is a Power Management IC with 2 buck regulators and 1 ADC. > + > +properties: > + compatible: > + enum: > + - adi,max77540 > + - adi,max77541 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + regulators: > + $ref: /schemas/regulator/adi,max77541-regulator.yaml# No improvements regarding bisectability - this patch fails. If you tested this patch, you would see it. Instead of ignoring comments, either implement them or ask for clarification. > + > +required: > + - compatible > + - reg > + - interrupts > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: adi,max77540 > + then: > + properties: > + regulator: You do not have 'regulator' property. > + properties: > + compatible: > + const: adi,max77540-regulator > + else: > + properties: > + regulator: Same problem. > + properties: > + compatible: > + const: adi,max77541-regulator > + > +additionalProperties: false > + Best regards, Krzysztof
