On Thu, Jan 12, 2023 at 12:32:11PM +0100, Lorenzo Bianconi wrote:
> > I have followed Jonathan's proposal and added this simple patch in
> > the definition of the ST_LSM6DSX_CHANNEL macro :
> >
> > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h
> > index d80ba2e688ed..9d18145d5041 100644
> > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h
> > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h
> > @@ -96,6 +96,7 @@ enum st_lsm6dsx_hw_id {
> > .storagebits = 16, \
> > .endianness = IIO_LE, \
> > }, \
> > + .ext_info = st_lsm6dsx_accel_ext_info, \
> > }
>
> I am fine with this approach, probably having a per-sensor mount_matrix is
> unnecessary. Can you please just rename st_lsm6dsx_accel_ext_info in
> st_lsm6dsx_ext_info?
>
The compilation fails because there is already something different with
that same name in drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:715:30: error: conflicting type qualifiers for ‘st_lsm6dsx_ext_info’
static const struct iio_info st_lsm6dsx_ext_info = {
^~~~~~~~~~~~~~~~~~~
In file included from drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c:31:0:
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h:498:46: note: previous definition of ‘st_lsm6dsx_ext_info’ was here
struct iio_chan_spec_ext_info __maybe_unused st_lsm6dsx_ext_info[] = {
Best regards
Philippe
