From: ye xingchen <ye.xingchen@xxxxxxxxxx> Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx> --- drivers/iio/light/lv0104cs.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/iio/light/lv0104cs.c b/drivers/iio/light/lv0104cs.c index c041fa0faa5d..c0e82ae12920 100644 --- a/drivers/iio/light/lv0104cs.c +++ b/drivers/iio/light/lv0104cs.c @@ -397,9 +397,9 @@ static ssize_t lv0104cs_show_calibscale_avail(struct device *dev, int i; for (i = 0; i < ARRAY_SIZE(lv0104cs_calibscales); i++) { - len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06d ", - lv0104cs_calibscales[i].val, - lv0104cs_calibscales[i].val2); + len += sysfs_emit_at(buf, len, "%d.%06d ", + lv0104cs_calibscales[i].val, + lv0104cs_calibscales[i].val2); } buf[len - 1] = '\n'; @@ -414,9 +414,9 @@ static ssize_t lv0104cs_show_scale_avail(struct device *dev, int i; for (i = 0; i < ARRAY_SIZE(lv0104cs_scales); i++) { - len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06d ", - lv0104cs_scales[i].val, - lv0104cs_scales[i].val2); + len += sysfs_emit_at(buf, len, "%d.%06d ", + lv0104cs_scales[i].val, + lv0104cs_scales[i].val2); } buf[len - 1] = '\n'; @@ -431,9 +431,9 @@ static ssize_t lv0104cs_show_int_time_avail(struct device *dev, int i; for (i = 0; i < ARRAY_SIZE(lv0104cs_int_times); i++) { - len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06d ", - lv0104cs_int_times[i].val, - lv0104cs_int_times[i].val2); + len += sysfs_emit_at(buf, len, "%d.%06d ", + lv0104cs_int_times[i].val, + lv0104cs_int_times[i].val2); } buf[len - 1] = '\n'; -- 2.25.1