From: ye xingchen <ye.xingchen@xxxxxxxxxx> Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx> --- drivers/iio/light/ltr501.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c index bdbd918213e4..436f060a34e2 100644 --- a/drivers/iio/light/ltr501.c +++ b/drivers/iio/light/ltr501.c @@ -1116,9 +1116,9 @@ static ssize_t ltr501_show_proximity_scale_avail(struct device *dev, for (i = 0; i < info->ps_gain_tbl_size; i++) { if (info->ps_gain[i].scale == LTR501_RESERVED_GAIN) continue; - len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06d ", - info->ps_gain[i].scale, - info->ps_gain[i].uscale); + len += sysfs_emit_at(buf, len, "%d.%06d ", + info->ps_gain[i].scale, + info->ps_gain[i].uscale); } buf[len - 1] = '\n'; @@ -1138,9 +1138,9 @@ static ssize_t ltr501_show_intensity_scale_avail(struct device *dev, for (i = 0; i < info->als_gain_tbl_size; i++) { if (info->als_gain[i].scale == LTR501_RESERVED_GAIN) continue; - len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06d ", - info->als_gain[i].scale, - info->als_gain[i].uscale); + len += sysfs_emit_at(buf, len, "%d.%06d ", + info->als_gain[i].scale, + info->als_gain[i].uscale); } buf[len - 1] = '\n'; -- 2.25.1