From: ye xingchen <ye.xingchen@xxxxxxxxxx> Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx> --- drivers/iio/accel/mma8452.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index f97fb68e3a71..7ba3c743e6f6 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -266,8 +266,7 @@ static ssize_t mma8452_show_int_plus_micros(char *buf, const int (*vals)[2], size_t len = 0; while (n-- > 0) - len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06d ", - vals[n][0], vals[n][1]); + len += sysfs_emit_at(buf, len, "%d.%06d ", vals[n][0], vals[n][1]); /* replace trailing space by newline */ buf[len - 1] = '\n'; @@ -423,7 +422,7 @@ static ssize_t mma8452_show_os_ratio_avail(struct device *dev, val = mma8452_os_ratio[j][i]; - len += scnprintf(buf + len, PAGE_SIZE - len, "%d ", val); + len += sysfs_emit_at(buf, len, "%d ", val); } buf[len - 1] = '\n'; -- 2.25.1
