From: ye xingchen <ye.xingchen@xxxxxxxxxx> Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx> --- drivers/iio/accel/bma180.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c index eb697eeb4301..9e3e5dfdded7 100644 --- a/drivers/iio/accel/bma180.c +++ b/drivers/iio/accel/bma180.c @@ -488,8 +488,7 @@ static ssize_t bma180_show_avail(char *buf, const int *vals, unsigned int n, for (i = 0; i < n; i++) { if (!vals[i]) continue; - len += scnprintf(buf + len, PAGE_SIZE - len, - micros ? "0.%06d " : "%d ", vals[i]); + len += sysfs_emit_at(buf, len, micros ? "0.%06d " : "%d ", vals[i]); } buf[len - 1] = '\n'; -- 2.25.1