Hello, I'm sorry for the confusion caused by me sending revisions as replies. I've now addresses the points raised. As I'm unfamiliar with mailing lists any recommendation on making the process more seamless is welcome. Thank you for your time! v2: - Patch 1/4: - Remove unnecessary comments. - Change return type of functions to bool. (introduced an error, fixed in v4) - Swallows return value of a function. (fixed in v4) - Patch 2/4: - Create this 'noop' patch that just adds the LISS sensors to the custom sensor match table. - Patch 3/4: - Remove some unnecessary newlines in function calls. - Patch 4/4: - Allow for 1 byte human presence reports. v3: - Patch 2/4 - Add missing 'Signed-Off-By' v4: - Patch 1/4: - Fix return value and error codes on property query. - Document and ignore return values for queries of optionally matched properties. - Don't modify *known in _get_known, return error when not matched. - Remove comment on newly added sensors from commit message. - Patch 4/4: - Clean up switch statement. Regards, Philipp Jungkamp Philipp Jungkamp (4): HID: hid-sensor-custom: Allow more custom iio sensors HID: hid-sensor-custom: Add LISS custom sensors IIO: hid-sensor-als: Use generic usage IIO: hid-sensor-prox: Use generic usage drivers/hid/hid-sensor-custom.c | 233 +++++++++++++++++++--------- drivers/iio/light/hid-sensor-als.c | 27 ++-- drivers/iio/light/hid-sensor-prox.c | 37 +++-- include/linux/hid-sensor-ids.h | 1 + 4 files changed, 199 insertions(+), 99 deletions(-) -- 2.38.1