On Mon, 26 Sep 2022, Rob Herring wrote: > On Mon, Sep 26, 2022 at 2:46 AM Lee Jones <lee@xxxxxxxxxx> wrote: > > > > On Sat, 24 Sep 2022, Jonathan Cameron wrote: > > > > > On Fri, 23 Sep 2022 10:51:24 +0800 > > > ChiaEn Wu <peterwu.pub@xxxxxxxxx> wrote: > > > > > > > From: ChiaEn Wu <chiaen_wu@xxxxxxxxxxx> > > > > > > > > MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger > > > > with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight > > > > driver, display bias voltage supply, one general purpose LDO, and the > > > > USB Type-C & PD controller complies with the latest USB Type-C and PD > > > > standards. > > > > > > > > Add support for the MT6370 ADC driver for system monitoring, including > > > > charger current, voltage, and temperature. > > > > > > > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > > > > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > > > Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > > > Signed-off-by: ChiaEn Wu <chiaen_wu@xxxxxxxxxxx> > > > > > > This will have to either wait for next cycle, or go through mfd because > > > of the dt-bindings include which is in the mfd tree. > > > > > > Please make those dependencies clear in new versions. > > > > If the bindings come together in -next, then subsequently in Mainline, > > it shouldn't really matter. > > Except that the bindings haven't come together and at this point may > not for 6.1. linux-next has been warning for weeks because the child > device schemas haven't been applied. I've said it before, all the > schemas for MFD devices need to be applied together. Or at least the > MFD schema needs to get applied last. > > Furthermore, subsequent versions of this don't get tested and we end > up with more warnings[1]. > > It's only your IIO tree that the DT > > tooling with complain about, right? > > And the MFD tree... > > Please apply the LED bindings (patches 1 and 2) so we can get the > existing warnings fixed and address any new warnings. Who usually applies LED bindings? Looks as though they're good to go. -- Lee Jones [李琼斯]
