On Thu, 25 Aug 2022 23:06:01 +0300 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Wed, Aug 24, 2022 at 1:46 PM Vincent Whitchurch > <vincent.whitchurch@xxxxxxxx> wrote: > > > > From: Axel Jonsson <axel.jonsson@xxxxxxxx> > > > > Add support for triggered buffers. Just read the channels in a loop to > > keep things simple. > > ... > > > #include <linux/module.h> > > #include <linux/mod_devicetable.h> > > #include <linux/iio/iio.h> > > +#include <linux/interrupt.h> > > Ordering? > > But honestly, I prefer the linux/iio/* to be split in a separate group... > > > +#include <linux/iio/buffer.h> > > +#include <linux/iio/triggered_buffer.h> > > +#include <linux/iio/trigger_consumer.h> > > #include <linux/regulator/consumer.h> > > > > ...and be put here. > > ... > > > + device_index = spi_get_device_id(adc->spi)->driver_data; > > Hmm... Wondering if this can be derived from channel number or alike. > It is weirder than the name implies. Seem device_index is actually the chip type from amongst those the driver supports. That wants cleaning up, particularly there is also a chip_info structure. Various ways of doing it, but simplest is probably a set of callbacks covering the different data extraction methods in mcp320x_adc_conversion. Jonathan
