On Wed, Aug 24, 2022 at 1:46 PM Vincent Whitchurch <vincent.whitchurch@xxxxxxxx> wrote: > > From: Axel Jonsson <axel.jonsson@xxxxxxxx> > > Add support for triggered buffers. Just read the channels in a loop to > keep things simple. ... > #include <linux/module.h> > #include <linux/mod_devicetable.h> > #include <linux/iio/iio.h> > +#include <linux/interrupt.h> Ordering? But honestly, I prefer the linux/iio/* to be split in a separate group... > +#include <linux/iio/buffer.h> > +#include <linux/iio/triggered_buffer.h> > +#include <linux/iio/trigger_consumer.h> > #include <linux/regulator/consumer.h> > ...and be put here. ... > + device_index = spi_get_device_id(adc->spi)->driver_data; Hmm... Wondering if this can be derived from channel number or alike. -- With Best Regards, Andy Shevchenko