On Thu, Jun 30, 2022 at 12:25 PM Uwe Kleine-König <ukleinek@xxxxxxxxxx> wrote: > On 6/30/22 09:17, Andy Shevchenko wrote: > > On Thu, Jun 30, 2022 at 8:58 AM Uwe Kleine-König <ukleinek@xxxxxxxxxx> wrote: > >> > >> Don't emit a message for -ENOMEM, the kernel is already loud enough in > >> this case. Add a message if getting the GPIO or registering the iio > >> device fails and use dev_err_probe for improved behaviour on > >> -EPROBE_DEFER. > > > > Why do we need additional messages? > > I don't understand the question. Do you really wonder why there is a > benefit of an error message if a resource allocation in probe fails? > > Current state is that for Yves-Alexis (on Cc:) the driver is silent but > unbound. I guess that's because gpiod_get fails, but seeing a > confirmation in the kernel log would be nice. > > > They should be split in a separate patch, perhaps, with the explanation. > > > > Actually the rest I would split to two: converting to dev_err_probe() > > in the case where it's not right now, and dropping ENOMEM message. > > So we're at three patches: > > - drop ENOMEM message > - convert existing messages to dev_err_probe() > - introduce errors for devm_gpiod_get() and devm_iio_device_register() > > I can rework accordingly, but for me this looks a bit over engineered. Perhaps, but they three are about different stuff. -- With Best Regards, Andy Shevchenko
