Re: [PATCH] iio: humidity: dht11: Improve error reporting in .probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 30, 2022 at 8:58 AM Uwe Kleine-König <ukleinek@xxxxxxxxxx> wrote:
>
> Don't emit a message for -ENOMEM, the kernel is already loud enough in
> this case. Add a message if getting the GPIO or registering the iio
> device fails and use dev_err_probe for improved behaviour on
> -EPROBE_DEFER.

Why do we need additional messages?

They should be split in a separate patch, perhaps, with the explanation.

Actually the rest I would split to two: converting to dev_err_probe()
in the case where it's not right now, and dropping ENOMEM message.

-- 
With Best Regards,
Andy Shevchenko




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux