Hi Andy, On 18.06.22 11:53, Andy Shevchenko wrote: > > On Sat, Jun 18, 2022 at 2:15 AM Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote: >> >> This commit gathers minor cleanups in the current driver. >> >> In the device examples, "Xiaomi" is too generic, specific devices should be >> listed here. E.g. Xiaomi Redmi 2 seems to have YAS537 but it's not fully clear >> if this applies to all its variants. Samsung Galaxy S7 is often quoted in >> conjunction with YAS537. >> >> In the function yas530_get_calibration_data(), the debug dump was extended to >> 16 elements as this is the size of the calibration data array of YAS530. > > We do not accept or even consider contributions w/o SoB tag, sorry. I'm not used to the routines yet, sorry... > P.S. Reading briefly, split this to two patches: > 1) moving %*ph parameters out from stack; > 2) documentation and indentation fixes. There is also the change on memchr_inv(). Additionally on that line, I would also add the "if (a && b)" that you suggested in patch 8. So I'd split this patch into two, as recommended by you, but the second one would be "documentation and style fixes" including the changes on memchr_inv(). Kind regards, Jakob
