Hi Jonathan, On 18.06.22 17:00, Jonathan Cameron wrote: > > On Sat, 18 Jun 2022 02:13:14 +0200 > Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote: > >> This is a preparation for adding YAS537 variant. >> >> Rename functions used only by YAS530 & YAS532 from yas5xx to yas530_532. > > We've been bitten in the past by naming choices like this, so please > use yas530 only and rely on comments or code that makes it obvious that > it applies to the yas532 as well. Hm, ok. It's harder to keep the overview. But I can imagine adding up names can get out of control. I'll change it. For functions and registers used by all variants, I'd keep yas5xx or YAS5XX respectively. I hope that's ok. Again I'm not sure on the "Reviewed-by:" tags. Again the patch gets modified a lot, therefore I would remove the tags. ... Kind regards, Jakob
