On Mon, Jun 20, 2022 at 9:53 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On Mon, 20 Jun 2022 20:40:17 +0200 > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Mon, Jun 20, 2022 at 6:40 PM Jonathan Cameron > > <Jonathan.Cameron@xxxxxxxxxx> wrote: > > > On Mon, 20 Jun 2022 01:11:36 +0200 > > > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > > > On Sun, Jun 19, 2022 at 8:59 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: ... > > > > > drivers/iio/cdc/ad7746.c | 818 +++++++++++++++++++++++++++++++ > > > > > drivers/staging/iio/cdc/ad7746.c | 818 ------------------------------- > > > > > > > > It's a bit hard to review, perhaps you forgot to add -M -C when > > > > generating this patch? > > > > > > Specifically passed --no-renames because this is a direct file move - > > > I should have stated that though. > > > > > > The intent is to allow review of the full driver as being proposed for > > > move out of staging. > > > > In (my) practice it only makes review much harder without any > > additional benefits. Git is smart to understand renaming and in the > > diffstat there is a special line about renaming. > > > > > Including the bits that otherwise aren't > > > visible anywhere in the driver. I only do this (and ask for it from others) > > > for staging graduation patches. > > > > Perhaps somebody finds that useful, but me :-) > > > > I definitely do as lets me lazy and not apply the patches just do a review > + where do you comment on something in the original driver that is getting moved? > That particularly use case only really applies to drivers moving out of staging > though. Alternative is to paste the entire driver in the cover letter which > is not a great solution either... Ah, I think I got your point. You want somebody to go through the driver without applying series locally and tell if it looks okay to be out of the staging, This is fair point, but perhaps I trust you that much that I believe if anything is left, it's not a blocker of moving things out of staging. -- With Best Regards, Andy Shevchenko
